Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(background): handle unpeered wallets; retry without waiting interval #465

Merged
merged 31 commits into from
Aug 7, 2024

Conversation

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jul 31, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Jul 31, 2024

Extension builds preview

Name Link
Latest commit b1d5779
Latest job logs Run #10282090648
BadgeDownload
BadgeDownload

@github-actions github-actions bot added the area: popup Improvements or additions to extension popup label Jul 31, 2024
@sidvishnoi sidvishnoi changed the title fix(background): Handle unpeer wallet cases fix(background): handle unpeered wallets Aug 2, 2024
@github-actions github-actions bot added the area: tests Improvements or additions to tests label Aug 2, 2024
@sidvishnoi sidvishnoi changed the title fix(background): handle unpeered wallets fix(background): handle unpeered wallets; retry without waiting interval Aug 2, 2024
@raducristianpopa raducristianpopa marked this pull request as ready for review August 2, 2024 13:15
src/_locales/en/messages.json Outdated Show resolved Hide resolved
Comment on lines 95 to 96
"home_warn_invalidLinks": {
"message": "[TODO] Has invalid links. (UI)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@RabebOthmani
Copy link
Collaborator

@raducristianpopa are these still waiting for me?

@raducristianpopa
Copy link
Member

@raducristianpopa are these still waiting for me?

Yes. We added them here as well so you can see where and how they are displayed.

@RabebOthmani
Copy link
Collaborator

@raducristianpopa few thoughts before getting into the copy:
Across the extension, we use payment. Do we want to keep with payments (Unable to process a payment) or use sent money (unable to send money) ?
Thinking about the average user: will they understand what a peered or unpeered wallets mean? I think it's better to say we can't process the payment, you might need to check with your provider for more details

@RabebOthmani
Copy link
Collaborator

For the error message when a website is not monetized, let's go with "This site is not web monetized" (using web monetized on purpose to keep it in the context of web monetization)

@raducristianpopa
Copy link
Member

raducristianpopa commented Aug 5, 2024

Across the extension, we use payment. Do we want to keep with payments (Unable to process a payment) or use sent money (unable to send money) ?

Like you mentioned, we are using payment across the extension. Let's stick with this.

Thinking about the average user: will they understand what a peered or unpeered wallets mean? I think it's better to say we can't process the payment, you might need to check with your provider for more details

No, we should not mention peering for the end user. What I am not sure about is this part: you might need to check with your provider for more details. The user doesn't have any details about who the receiver is since we are not showing them the wallet addresses that we found in the page. What is the user going to tell to the support team for example?

@RabebOthmani
Copy link
Collaborator

No, we should not mention peering for the end user. What I am not sure about is this part: you might need to check with your provider for more details. The user doesn't have any details about who the receiver is since we are not showing them the wallet addresses that we found in the page. What is the user going to tell to the support team for example?

What I'm trying to communicate is the payment failed but that's not the extension's fault. How about : We are unable to process the payment due to issues beyond our control.

@RabebOthmani
Copy link
Collaborator

The last one, what do we mean by has invalid linked? Is that when it's a partial problem?

@raducristianpopa
Copy link
Member

raducristianpopa commented Aug 6, 2024

The last one, what do we mean by has invalid linked? Is that when it's a partial problem?

The has invalid links placeholder that we have, will be displayed to the user when the extension can not send money to the wallet addresses that were found in the page - continuous payments, not one time payments (in our case, mostly because on the peering). It's not a partial problem. For the partial problem - when we can send to at least one wallet address from the page, we are not going to show the warning.

@RabebOthmani
Copy link
Collaborator

We discussed all these scenarios from our perspective. Now that we're working on the message, I'm wondering if from the user's perspective, they are distinct scenarios. The one thing I could think about that would make this last case different (invalid links) is that potentially those links may change in the future. We could say " Currently, we are unable to process payments for this website. This might change in the future should you wish to keep the continuous payment going." What do you think @raducristianpopa

@RabebOthmani
Copy link
Collaborator

Final decision per the call: At the moment, you cannot pay this website.

Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design looks a bit off at the moment.

(And some tiny code changes suggested)

src/_locales/en/messages.json Outdated Show resolved Hide resolved
src/_locales/en/messages.json Outdated Show resolved Hide resolved
src/popup/pages/Home.tsx Outdated Show resolved Hide resolved
src/popup/pages/Home.tsx Outdated Show resolved Hide resolved
@sidvishnoi sidvishnoi merged commit 28def81 into main Aug 7, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the df--unpeered-wallet branch August 7, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: i18n area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests
Projects
None yet
4 participants