-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(background): handle unpeered wallets; retry without waiting interval #465
Conversation
dianafulga
commented
Jul 31, 2024
•
edited by sidvishnoi
Loading
edited by sidvishnoi
- Closes [BUG] No warning when sending to real wallet from rafiki.money #394
- Closes Don't wait for payment interval if there's a failure that we can retry #469
- Closes [BUG] One time payment still leaves sending wallet, despite receiving the message "Could not facilitate payment for current website." #296
- Part of Error handling/messages improvements #147
Get rid of `IS_TAB_MONETIZED` Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
TODO: memoizee same calls
…n-extension into df--unpeered-wallet
Extension builds preview
|
Co-authored-by: Radu-Cristian Popa <[email protected]> Co-authored-by: Diana Fulga <[email protected]>
Co-authored-by: Diana Fulga <[email protected]> Co-authored-by: Sid Vishnoi <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
src/_locales/en/messages.json
Outdated
"home_warn_invalidLinks": { | ||
"message": "[TODO] Has invalid links. (UI)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raducristianpopa are these still waiting for me? |
Yes. We added them here as well so you can see where and how they are displayed. |
@raducristianpopa few thoughts before getting into the copy: |
For the error message when a website is not monetized, let's go with "This site is not web monetized" (using web monetized on purpose to keep it in the context of web monetization) |
Like you mentioned, we are using payment across the extension. Let's stick with this.
No, we should not mention peering for the end user. What I am not sure about is this part: |
What I'm trying to communicate is the payment failed but that's not the extension's fault. How about : We are unable to process the payment due to issues beyond our control. |
The last one, what do we mean by has invalid linked? Is that when it's a partial problem? |
…n-extension into df--unpeered-wallet
The |
We discussed all these scenarios from our perspective. Now that we're working on the message, I'm wondering if from the user's perspective, they are distinct scenarios. The one thing I could think about that would make this last case different (invalid links) is that potentially those links may change in the future. We could say " Currently, we are unable to process payments for this website. This might change in the future should you wish to keep the continuous payment going." What do you think @raducristianpopa |
Final decision per the call: At the moment, you cannot pay this website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Sid Vishnoi <[email protected]>